Bug 210099

Summary:

TextManipulationController fails to replace a paragraph that ends with a br

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, koivisto, llivonbemel, mifenton, sihui_liu, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	wenson_hsieh: review+

Description Ryosuke Niwa 2020-04-07 00:59:29 PDT

Replacing a paragraph content fails with ContentChanged if the paragraph ends with a br.

Comment 1 Radar WebKit Bug Importer 2020-04-07 01:00:21 PDT

<rdar://problem/61381732>

Comment 2 Ryosuke Niwa 2020-04-07 01:03:11 PDT

Created attachment 395658 [details]
Fixes the bug

Comment 3 Louie Livon-Bemel 2020-04-07 10:45:57 PDT

(In reply to Ryosuke Niwa from comment #2)
> Created attachment 395658 [details]
> Fixes the bug

Typo: in `CompleteTextManipulationReplaceParagraphssSeparatedByWrappedBR`, 'Paragraphss' should be 'Paragraphs'.

Comment 4 Wenson Hsieh 2020-04-07 10:55:46 PDT

Comment on attachment 395658 [details]
Fixes the bug

r=me (with Louie’s comment above)

Comment 5 Ryosuke Niwa 2020-04-07 11:10:11 PDT

Committed r259647: <https://trac.webkit.org/changeset/259647>