| Summary: | WKWebViews should behave as if they had loaded something after restoring session state | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2020-04-06 22:47:04 PDT
Created attachment 395655 [details]
Patch
Comment on attachment 395655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395655&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:3482 > + m_hasCommittedAnyProvisionalLoads = true; It seems we are lying by setting this boolean to true here. Would it work to update whatever call site is relying on this flag to also check the m_sessionStateWasRestoredByAPIRequest instead? Comment on attachment 395655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395655&action=review >> Source/WebKit/UIProcess/WebPageProxy.cpp:3482 >> + m_hasCommittedAnyProvisionalLoads = true; > > It seems we are lying by setting this boolean to true here. Would it work to update whatever call site is relying on this flag to also check the m_sessionStateWasRestoredByAPIRequest instead? Changing this flag like this may have unintended consequences. For example, I believe we rely on this flag to avoid process-swapping when false. There is no reason to process swap after a session restore I believe. Created attachment 395883 [details]
Patch
Committed r259770: <https://trac.webkit.org/changeset/259770> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395883 [details]. Reverted in http://trac.webkit.org/r262845 |