Bug 210095

Summary: [Async overflow scroll] Horizontal scrolls can trigger unwanted back swipes
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: adachan, alex, cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Test
none
Patch thorton: review+, ews-feeder: commit-queue-

Simon Fraser (smfr)
Reported 2020-04-06 21:43:59 PDT
Created attachment 395652 [details] Test With async overflow scroll, scrolls inside a horizontally-scrollable container can end up doing a history swipe instead of a scroll.
Attachments
Test (1.25 KB, text/html)
2020-04-06 21:43 PDT, Simon Fraser (smfr) 		no flags
Details
Patch (37.94 KB, patch)
2020-04-08 14:51 PDT, Simon Fraser (smfr) 		thorton: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-04-06 21:44:13 PDT
<rdar://problem/61376245>
Simon Fraser (smfr)
Comment 2 2020-04-08 14:51:08 PDT
Created attachment 395872 [details] Patch
Tim Horton
Comment 3 2020-04-08 15:22:27 PDT
Comment on attachment 395872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395872&action=review > Source/WebCore/platform/cocoa/ScrollController.mm:107 > + // FIXME: Trying to decide if a gesture is horizontal or vertical at the "began" phase is very error-prone. This likely wants something more like a generalized VGC::PendingSwipeTracker
EWS
Comment 4 2020-04-09 05:23:40 PDT
Found 2 new test failures: http/tests/adClickAttribution/anchor-tag-attributes-validation.html, http/tests/security/anchor-download-block-crossorigin.html
Simon Fraser (smfr)
Comment 5 2020-04-09 09:34:52 PDT
https://trac.webkit.org/changeset/259805/webkit
Simon Fraser (smfr)
Comment 6 2020-04-29 07:46:13 PDT
*** Bug 211049 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.