| Summary: | [Async overflow scroll] Horizontal scrolls can trigger unwanted back swipes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | Scrolling | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | adachan, alex, cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Safari Technology Preview | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 395872 [details]
Patch
Comment on attachment 395872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395872&action=review > Source/WebCore/platform/cocoa/ScrollController.mm:107 > + // FIXME: Trying to decide if a gesture is horizontal or vertical at the "began" phase is very error-prone. This likely wants something more like a generalized VGC::PendingSwipeTracker Found 2 new test failures: http/tests/adClickAttribution/anchor-tag-attributes-validation.html, http/tests/security/anchor-download-block-crossorigin.html *** Bug 211049 has been marked as a duplicate of this bug. *** |
Created attachment 395652 [details] Test With async overflow scroll, scrolls inside a horizontally-scrollable container can end up doing a history swipe instead of a scroll.