| Summary: | VisitedLinkStore.messages.in and VisitedLinkStore::addVisitedLinkHashFromPage() don't agree on type of `linkHash` | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
| Component: | WebKit2 | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=210115 | ||||||||
| Attachments: |
|
||||||||
Created attachment 395651 [details]
Patch v1
Comment on attachment 395651 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=395651&action=review > Source/WebKit/Scripts/webkit/messages.py:618 > + 'WebCore::SharedStringHash': ['<WebCore/SharedStringHash.h>'], Why is this needed? Seems like this would be the default. Comment on attachment 395651 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=395651&action=review >> Source/WebKit/Scripts/webkit/messages.py:618 >> + 'WebCore::SharedStringHash': ['<WebCore/SharedStringHash.h>'], > > Why is this needed? Seems like this would be the default. Oops, it's not. I'm new to this code. Thanks! Created attachment 395685 [details]
Patch v2
Committed r259637: <https://trac.webkit.org/changeset/259637> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395685 [details]. |
VisitedLinkStore.messages.in and VisitedLinkStore::addVisitedLinkHashFromPage() don't agree on type of `linkHash`. messages -> VisitedLinkStore { AddVisitedLinkHashFromPage(WebKit::WebPageProxyIdentifier pageProxyID, uint64_t linkHash) } using SharedStringHash = uint32_t; void VisitedLinkStore::addVisitedLinkHashFromPage(WebPageProxyIdentifier pageProxyID, SharedStringHash linkHash) { [...] } <rdar://problem/60334644>