Bug 210084

Summary: Add release asserts to KeyframeEffectStack::ensureEffectsAreSorted()
Product: WebKit Reporter: Doug Kelly <dougk>
Component: AnimationsAssignee: Doug Kelly <dougk>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ggaren, graouts, graouts, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Mac   
OS: macOS 10.15   
Attachments:
Description Flags
Patch
none
Patch none

Description Doug Kelly 2020-04-06 17:26:13 PDT 
KeyframeEffectStack::ensureEffectsAreSorted() has several areas where either null pointers or an unexpected condition could cause a crash that's further away from the actual failure.  To make these issues easier to detect and troubleshoot, add several RELEASE_ASSERTs to test these cases explicitly.

<rdar://problem/61359275>
Comment 1 Doug Kelly 2020-04-06 17:30:36 PDT 
Created attachment 395638 [details]
Patch
Comment 2 Doug Kelly 2020-04-06 20:23:48 PDT 
Created attachment 395647 [details]
Patch
Comment 3 EWS 2020-04-07 01:26:05 PDT 
Committed r259630: <https://trac.webkit.org/changeset/259630>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395647 [details].