Bug 210052

Summary: Make sure playback of remote audio tracks is stable even if pages are using webaudio
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, peng.liu6, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Alternative Fix
none
Patch none

youenn fablet
Reported 2020-04-06 09:24:04 PDT
Make sure playback of remote audio track is stable even if pages are using webaudio
Attachments
Patch (8.94 KB, patch)
2020-04-06 10:46 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (18.27 KB, patch)
2020-04-06 11:17 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Alternative Fix (2.60 KB, patch)
2020-04-06 14:59 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (18.27 KB, patch)
2020-04-07 04:23 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-04-06 10:46:50 PDT
Created attachment 395585 [details] Patch
youenn fablet
Comment 2 2020-04-06 11:17:49 PDT
Created attachment 395590 [details] Patch
Jer Noble
Comment 3 2020-04-06 14:53:01 PDT
Comment on attachment 395590 [details] Patch I think this attachment was for a different bug (#210044).
Jer Noble
Comment 4 2020-04-06 14:59:06 PDT
Created attachment 395621 [details] Alternative Fix
youenn fablet
Comment 5 2020-04-07 04:23:38 PDT
Created attachment 395668 [details] Patch
Jer Noble
Comment 6 2020-04-07 10:24:20 PDT
Comment on attachment 395621 [details] Alternative Fix This fixes one class of dropout bugs when sending audio from WebRTC through WebAudio, but does not fix everything. Regardless, we should land this and follow up with more fixes.
EWS
Comment 7 2020-04-07 10:26:45 PDT
Committed r259644: <https://trac.webkit.org/changeset/259644> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395621 [details].
Radar WebKit Bug Importer
Comment 8 2020-04-07 10:27:16 PDT
<rdar://problem/61398793>
Note You need to log in before you can comment on or make changes to this bug.