| Summary: | ProcessAssertion should use ASCIILiteral for its reason | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, darin, ggaren, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=209984 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 209990 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2020-04-06 08:27:32 PDT
Created attachment 395568 [details]
Patch
Why? (In reply to Alex Christensen from comment #2) > Why? https://bugs.webkit.org/show_bug.cgi?id=209984#c3 Comment on attachment 395568 [details]
Patch
This seems silly to me. The API takes an NSString. Using stringWithCString and NSASCIIStringEncoding doesn't improve anything. This is just documenting that all the strings we use happen to be ASCII right now.
(In reply to Alex Christensen from comment #4) > This seems silly to me. The API takes an NSString. Using stringWithCString > and NSASCIIStringEncoding doesn't improve anything. This is just > documenting that all the strings we use happen to be ASCII right now. Seems great to me. Why turn literals into WTF::String just to turn them into NSString later? These are labels from the code, not arbitrary strings. Committed r259579: <https://trac.webkit.org/changeset/259579> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395568 [details]. I guess that's true. This reduces a few WTF::String constructions. |