Bug 210039

Summary:

ARM64 moveConditionallyDouble() for DoubleNotEqualAndOrdered is wrong.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	ysuzuki: review+

Description Mark Lam 2020-04-05 14:44:45 PDT

For the scenario where the dest register is same as the then case register, there is one case instruction that should be executed based on the overflow flag to test for unordered operands.  Instead, we were testing for the not equal condition.  This bug was caught by testmasm.

Comment 1 Radar WebKit Bug Importer 2020-04-05 14:45:12 PDT

<rdar://problem/61321778>

Comment 2 Mark Lam 2020-04-05 14:53:10 PDT

Created attachment 395530 [details]
proposed patch.

Comment 3 Yusuke Suzuki 2020-04-05 15:55:59 PDT

Comment on attachment 395530 [details]
proposed patch.

r=me

Comment 4 Mark Lam 2020-04-05 16:00:30 PDT

Thanks for the review.  Landed in r259556: <http://trac.webkit.org/r259556>.