Bug 210038

Summary:

[Clang 10] Fix -Wimplicit-int-float-conversion compilation warnings in JavaScriptCore

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

JavaScriptCore

Assignee:

Fujii Hironori <Hironori.Fujii>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

204834

Attachments:

Description	Flags
Patch	none

Description Fujii Hironori 2020-04-05 14:26:14 PDT

[Clang 10] Fix -Wimplicit-int-float-conversion compilation warnings in JavaScriptCore

This is a sub-task of Bug 204834.

Clang 10 reports a compilation warning in JavaScriptCore:

> ..\..\Source\JavaScriptCore\bytecode/CodeBlock.cpp(3002,24): warning: implicit conversion from 'unsigned long long' to 'double' changes value from 18446744073709551615 to 18446744073709551616 [-Wimplicit-int-float-conversion]
>     if (doubleResult > std::numeric_limits<size_t>::max())
>                      ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

See also: r259537 (which is for WTF)

Comment 1 Fujii Hironori 2020-04-05 14:32:56 PDT

Created attachment 395528 [details]
Patch

Comment 2 Fujii Hironori 2020-04-06 13:08:16 PDT

Comment on attachment 395528 [details]
Patch

Clearing flags on attachment: 395528

Committed r259588: <https://trac.webkit.org/changeset/259588>

Comment 3 Fujii Hironori 2020-04-06 13:08:20 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2020-04-06 13:09:14 PDT

<rdar://problem/61355692>