Bug 210012

Summary: run-api-tests spew "setup_environ_for_server" in verbose mode
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Daniel Bates 2020-04-04 18:16:09 PDT 
Seen on <https://ews-build.webkit.org/#/builders/9/builds/21136> (Attachment #395467 [details]; patch for bug 210010). run-api-tests spew "setup_environ_for_server" in verbose mode. This logging is really noisy and does not seem very informative. If useful, cons the code be made more deterministic to make it unneeded? If not, can it be made more informative or a full sentence?
Comment 1 Radar WebKit Bug Importer 2020-04-04 18:16:19 PDT 
<rdar://problem/61306056>
Comment 2 Jonathan Bedard 2020-04-06 08:04:46 PDT 
Created attachment 395564 [details]
Patch
Comment 3 Jonathan Bedard 2020-04-06 08:08:14 PDT 
Originally, this logging was part of a group of logging statements intended to help debug run-api-tests in the event something went wrong. The other statements are in functions which do something and are run infrequently. setup_environ_for_server just returns a dictionary, so we call it very frequently because it's low cost. The fact that it is low cost means we shouldn't be logging when we call it.
Comment 4 EWS 2020-04-06 10:01:53 PDT 
Committed r259574: <https://trac.webkit.org/changeset/259574>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395564 [details].