| Summary: | Remove LockHistory parameter from loadWithNavigationAction | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||
| Component: | New Bugs | Assignee: | Rob Buis <rbuis> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, darin, ews-watchlist, japhet, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Safari Technology Preview | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Rob Buis
2020-04-04 10:28:28 PDT
Created attachment 395456 [details]
Patch
Comment on attachment 395456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395456&action=review > Source/WebCore/loader/FrameLoader.cpp:1424 > - loadWithNavigationAction(request, WTFMove(action), lockHistory, newLoadType, WTFMove(formState), allowNavigationToInvalidURL, frameLoadRequest.downloadAttribute(), [this, isRedirect, sameURL, newLoadType, protectedFrame = makeRef(m_frame), completionHandler = completionHandlerCaller.release()] () mutable { > + loadWithNavigationAction(request, WTFMove(action), newLoadType, WTFMove(formState), allowNavigationToInvalidURL, frameLoadRequest.downloadAttribute(), [this, isRedirect, sameURL, newLoadType, protectedFrame = makeRef(m_frame), completionHandler = completionHandlerCaller.release()] () mutable { How did you determine that it’s not necessary to call setLockHistory on the action here, the way you did in FrameLoader::loadWithNavigationAction? Comment on attachment 395456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395456&action=review >> Source/WebCore/loader/FrameLoader.cpp:1424 >> + loadWithNavigationAction(request, WTFMove(action), newLoadType, WTFMove(formState), allowNavigationToInvalidURL, frameLoadRequest.downloadAttribute(), [this, isRedirect, sameURL, newLoadType, protectedFrame = makeRef(m_frame), completionHandler = completionHandlerCaller.release()] () mutable { > > How did you determine that it’s not necessary to call setLockHistory on the action here, the way you did in FrameLoader::loadWithNavigationAction? Oh, I see now. It’s already done above. Committed r259544: <https://trac.webkit.org/changeset/259544> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395456 [details]. |