Bug 209993

Summary: TestWebKitAPI.WebKit.DefaultDisplayName and TestWebKitAPI.WebKit.CustomDisplayName are flaky failures
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=211299
Attachments:
Description Flags
Patch none

Description Ryan Haddad 2020-04-03 17:16:47 PDT
TestWebKitAPI.WebKit.DefaultDisplayName is a flaky failure


    TestWebKitAPI.WebKit.DefaultDisplayName
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
        
        /Volumes/Data/slave/mojave-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm:69
        Expected equality of these values:
          name
            Which is: "com.apple.WebKit.WebContent"
          @"TestWebKitAPI Web Content"
            Which is: "TestWebKitAPI Web Content"
        

https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKit.DefaultDisplayName
Comment 1 Radar WebKit Bug Importer 2020-04-03 17:17:02 PDT
<rdar://problem/61282602>
Comment 2 Ryan Haddad 2020-04-03 17:19:02 PDT
The test was added with https://trac.webkit.org/changeset/257225/webkit

The first failure I see on the results database is @ r258914

It isn't immediately clear to me when this regressed.
Comment 3 Ryan Haddad 2020-04-16 17:15:37 PDT
TestWebKitAPI.WebKit.CustomDisplayName is also flaky (it was also added in r257225):

    TestWebKitAPI.WebKit.CustomDisplayName
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
        
        /Volumes/Data/slave/mojave-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm:55
        Expected equality of these values:
          name
            Which is: "TestWebKitAPI Web Content"
          displayNameToSet
            Which is: "test display name"

https://results.webkit.org/?suite=api-tests&suite=api-tests&test=TestWebKitAPI.WebKit.DefaultDisplayName&test=TestWebKitAPI.WebKit.CustomDisplayName
Comment 4 Alex Christensen 2020-04-29 16:05:39 PDT
Created attachment 398005 [details]
Patch
Comment 5 EWS 2020-04-30 15:37:32 PDT
Committed r260971: <https://trac.webkit.org/changeset/260971>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398005 [details].