Bug 209973

Summary:

Remove _setIsNavigatingToAppBoundDomain testing SPI

Product:

WebKit

Reporter:

Kate Cheney <katherine_cheney>

Component:

WebKit Misc.

Assignee:

Kate Cheney <katherine_cheney>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Kate Cheney 2020-04-03 10:14:04 PDT

We no longer need a testing SPI to set a webView as navigating to an app-bound domain. We can just load a local file.

Comment 1 Radar WebKit Bug Importer 2020-04-03 10:14:31 PDT

<rdar://problem/61264350>

Comment 2 Kate Cheney 2020-04-03 10:22:12 PDT

Created attachment 395390 [details]
Patch

Comment 3 David Kilzer (:ddkilzer) 2020-04-03 11:35:22 PDT

Comment on attachment 395390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395390&action=review

r=me assuming EWS passes.  Consider renaming `request2` as well.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:239
> +    NSURLRequest *request2 = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"in-app-browser-privacy-local-file" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];

Nit: `request2` isn't a great variable name.  Better to reuse `request` from above (since it's no longer used), or change it to something like `localFileRequest` or `fileRequest`.

Comment 4 Kate Cheney 2020-04-03 13:07:21 PDT

Created attachment 395406 [details]
Patch for landing

Comment 5 Kate Cheney 2020-04-03 13:07:52 PDT

(In reply to David Kilzer (:ddkilzer) from comment #3)
> Comment on attachment 395390 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395390&action=review
> 
> r=me assuming EWS passes.  Consider renaming `request2` as well.
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:239
> > +    NSURLRequest *request2 = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"in-app-browser-privacy-local-file" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
> 
> Nit: `request2` isn't a great variable name.  Better to reuse `request` from
> above (since it's no longer used), or change it to something like
> `localFileRequest` or `fileRequest`.

Thanks! I reused 'request' in the patch for landing.

Comment 6 EWS 2020-04-03 13:33:55 PDT

Committed r259507: <https://trac.webkit.org/changeset/259507>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395406 [details].