Bug 209967

Summary: Add logging to help diagnose <webkit.org/b/209685>
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: Tools / TestsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, megan_gardner, ryanhaddad, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Wenson Hsieh
Reported 2020-04-03 08:27:02 PDT
SSIA
Attachments
Patch (3.32 KB, patch)
2020-04-03 08:56 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-04-03 08:56:12 PDT
Created attachment 395380 [details] Patch
Megan Gardner
Comment 2 2020-04-03 09:39:24 PDT
Comment on attachment 395380 [details] Patch Should these be behind some sort of flag, or is the intention to remove them once we have a fix. I’m not jazzed about the idea of unguarded logging that can be left behind for forever.
EWS
Comment 3 2020-04-03 09:43:19 PDT
Committed r259465: <https://trac.webkit.org/changeset/259465> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395380 [details].
Wenson Hsieh
Comment 4 2020-04-03 10:59:28 PDT
(In reply to Megan Gardner from comment #2) > Comment on attachment 395380 [details] > Patch > > Should these be behind some sort of flag, or is the intention to remove them > once we have a fix. I’m not jazzed about the idea of unguarded logging that > can be left behind for forever. These will be removed after we’re able to debug the issue, ideally as a part of the patch that will fix these tests.
Note You need to log in before you can comment on or make changes to this bug.