Bug 209965

Summary:

[ews] Improve error message when patch fails to apply to trunk

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2020-04-03 07:25:57 PDT

[ews] Improve error message when patch fails to apply to trunk. Current error message is 'Patch does not apply', this might be confusing for few people (especially new contributors).

Better wording would be: 'Tools/Scripts/svn-apply failed to apply patch 123456 to trunk'.

Comment 1 Aakash Jain 2020-04-03 07:30:37 PDT

Created attachment 395374 [details]
Patch

Comment 2 Aakash Jain 2020-04-03 07:31:33 PDT

Sample run: https://ews-build.webkit-uat.org/#/builders/34/builds/137
Sample bug comment: https://bugs.webkit.org/show_bug.cgi?id=179531#c35

Comment 3 EWS 2020-04-03 09:26:57 PDT

Committed r259464: <https://trac.webkit.org/changeset/259464>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395374 [details].

Comment 4 Radar WebKit Bug Importer 2020-04-03 09:27:13 PDT

<rdar://problem/61262348>