| Summary: | REGRESSION (r258525): Leak of NSMutableAttributedString in -[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:] | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | Accessibility | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, darin, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=209980 | ||||||
| Bug Depends on: | 209129 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Created attachment 395308 [details]
Patch v1
Comment on attachment 395308 [details]
Patch v1
Thanks for catching that Dave. Strange that we were not using a RetainPtr.
Committed r259428: <https://trac.webkit.org/changeset/259428> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395308 [details]. |
Leak of NSMutableAttributedString in -[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]. [...] RefPtr<Range> range = [protectedSelf rangeForTextMarkerRange:textMarkerRange]; NSMutableAttributedString* attrString = [[NSMutableAttributedString alloc] init]; if (!range) return nil; // LEAK. TextIterator it(*range); [...]