| Summary: | Move Intl tests from LayoutTests to JSTests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||
| Component: | JavaScriptCore | Assignee: | Ross Kirsling <ross.kirsling> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=210085 | ||||||||
| Attachments: |
|
||||||||
|
Description
Ross Kirsling
2020-04-02 13:22:43 PDT
Created attachment 395292 [details]
Patch
Sorry if this is a bit tricky to review due to updating the assertion style of the test cases. I do recommend that we migrate tests from LayoutTests/js to JSTests/stress any time we're bitten by them as a general practice, but I might not necessarily recommend taking the time to update the assertion style like this in the future. Grr, I tried to relax the skips a bit, but apparently that part will need to wait until after bug 209694. Created attachment 395304 [details]
Patch
Comment on attachment 395304 [details]
Patch
r=me
Committed r259480: <https://trac.webkit.org/changeset/259480> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395304 [details]. |