Bug 209918

Summary:

Rename some wheel-event related functions

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser, webkit-bug-importer, wenson_hsieh, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	zalan: review+

Description Simon Fraser (smfr) 2020-04-02 12:12:20 PDT

Rename some wheel-event related functions

Comment 1 Simon Fraser (smfr) 2020-04-02 12:14:32 PDT

Created attachment 395287 [details]
Patch

Comment 2 Wenson Hsieh 2020-04-02 12:18:43 PDT

Comment on attachment 395287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395287&action=review

> Source/WebCore/ChangeLog:8
> +        Rename some funcitons to describe what they do, rather than being generic "platform" things, to make

Nit - “funcitons"

> Source/WebCore/page/EventHandler.cpp:2714
> +void EventHandler::clearLatchedStateTimeFired()

Nit - clearLatchedStateTimerFired instead?

Comment 3 Simon Fraser (smfr) 2020-04-02 14:45:01 PDT

https://trac.webkit.org/changeset/259416/webkit

Comment 4 Radar WebKit Bug Importer 2020-04-02 14:45:14 PDT

<rdar://problem/61227489>