Bug 209903

Summary: Video previews on shutterstock.com don't play when tapped on iPadOS
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, japhet, jer.noble, macpherson, menard, philipj, sergio, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch wenson_hsieh: review+

Description Antoine Quint 2020-04-02 06:36:27 PDT 
Video previews on shutterstock.com don't play when tapped on iPadOS
Comment 1 Antoine Quint 2020-04-02 06:40:15 PDT 
Created attachment 395264 [details]
Patch
Comment 2 Antoine Quint 2020-04-02 06:40:20 PDT 
<rdar://problem/58844166>
Comment 3 Wenson Hsieh 2020-04-02 07:57:31 PDT 
Comment on attachment 395264 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395264&action=review

> Source/WebCore/loader/DocumentLoader.h:138
> +    Allow,
> +    Deny,

Nit - sounds a bit weird for a `CanPrevent~` enum to have values of Allow and Deny. Maybe just Default, No, and Yes?
Comment 4 Antoine Quint 2020-04-02 08:07:20 PDT 
Created attachment 395267 [details]
Patch
Comment 5 Antoine Quint 2020-04-02 08:54:24 PDT 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 395264 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395264&action=review
> 
> > Source/WebCore/loader/DocumentLoader.h:138
> > +    Allow,
> > +    Deny,
> 
> Nit - sounds a bit weird for a `CanPrevent~` enum to have values of Allow
> and Deny. Maybe just Default, No, and Yes?

The newer patch removes the desktop-specific part of the quirk.
Comment 6 Antoine Quint 2020-04-02 08:58:18 PDT 
Committed r259387: <https://trac.webkit.org/changeset/259387>