Bug 209894

Summary:

HTMLFormElement should use WeakPtr to keep track of its associated elements

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Forms

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cdumez, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, koivisto, mifenton, webkit-bug-importer, wenson_hsieh, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Uses WeakPtr	wenson_hsieh: review+

Description Ryosuke Niwa 2020-04-01 22:08:23 PDT

HTMLFormElement currently has raw pointers to FormAssociatedElement. Replace them with WeakPtr.

Comment 1 Ryosuke Niwa 2020-04-01 22:19:50 PDT

Created attachment 395244 [details]
Uses WeakPtr

Comment 2 Ryosuke Niwa 2020-04-02 09:50:23 PDT

Ping reviewers.

Comment 3 Wenson Hsieh 2020-04-02 09:55:44 PDT

Comment on attachment 395244 [details]
Uses WeakPtr

View in context: https://bugs.webkit.org/attachment.cgi?id=395244&action=review

> Source/WebCore/html/HTMLFormElement.cpp:890
> +        

Nit - extra newline here.

Comment 4 Ryosuke Niwa 2020-04-02 11:04:14 PDT

Committed r259393: <https://trac.webkit.org/changeset/259393>

Comment 5 Radar WebKit Bug Importer 2020-04-02 11:05:16 PDT

<rdar://problem/61216706>

Comment 6 Ryosuke Niwa 2020-04-02 11:07:29 PDT

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 395244 [details]
> Uses WeakPtr
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=395244&action=review
> 
> > Source/WebCore/html/HTMLFormElement.cpp:890
> > +        
> 
> Nit - extra newline here.

Oh oops, I missed that.

Comment 7 Ryosuke Niwa 2020-04-02 11:08:22 PDT

Fixed that in https://trac.webkit.org/changeset/259394