Bug 209872

Summary: [css-flexbox] flex-grow property should be animatable
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: CSSAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, darin, dino, esprehn+autocc, ews-watchlist, glenn, graouts, graouts, kondapallykalyan, pdr, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=180435
https://bugs.webkit.org/show_bug.cgi?id=209874
https://bugs.webkit.org/show_bug.cgi?id=209876
Attachments:
Description Flags
Patch
graouts: review+, ews-feeder: commit-queue-
Patch for landing none

Description Carlos Alberto Lopez Perez 2020-04-01 13:07:41 PDT 
The flex-grow property must be animatable

https://drafts.csswg.org/css-flexbox/#flex-grow-property

Here its a simple test case: https://codepen.io/cl0p3z/pen/yLNrNyN

Works on Chrome and Firefox. Fails on WebKit.

This its tested by WPT css/css-flexbox/animation/flex-grow-interpolation.html
Comment 1 Sergio Villar Senin 2020-10-14 05:49:01 PDT 
Created attachment 411314 [details]
Patch
Comment 2 Antoine Quint 2020-10-14 05:58:20 PDT 
Comment on attachment 411314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411314&action=review

r+ assuming EWS bots are happy as well, thanks for adding this.

> Source/WebCore/rendering/style/RenderStyle.h:1104
> +    void setFlexGrow(float f) { float v = std::max<float>(f, 0.f); SET_NESTED_VAR(m_rareNonInheritedData, flexibleBox, flexGrow, v); }

Perhaps spell out what `v` stands for here. Since you're clamping, perhaps call that out in the variable name.
Comment 3 Sergio Villar Senin 2020-10-14 07:21:06 PDT 
Created attachment 411321 [details]
Patch for landing
Comment 4 Sergio Villar Senin 2020-10-15 00:55:04 PDT 
Committed r268516: <https://trac.webkit.org/changeset/268516>
Comment 5 Radar WebKit Bug Importer 2020-10-15 00:56:17 PDT 
<rdar://problem/70325825>