Bug 209868

Summary: Context menu for local storage puts quotes around key and value
Product: WebKit Reporter: Jon Lee <jonlee>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 13   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jon Lee
Reported 2020-04-01 11:21:27 PDT
In the LocalStorage table, right clicking on a cell shows a context menu that either says Edit "Key" Edit "Value" based on the cell column. Using quotes is weird because it's not the name of the key, and unnecessary. Typically it would just say Edit Key Edit Value
Attachments
Patch (2.80 KB, patch)
2020-04-01 12:58 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (3.10 KB, patch)
2020-04-02 16:57 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-04-01 12:58:14 PDT
Created attachment 395193 [details] Patch
Joseph Pecoraro
Comment 2 2020-04-01 13:07:30 PDT
Comment on attachment 395193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395193&action=review rs=me > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:454 > localizedStrings["Edit \u201C%s\u201D"] = "Edit \u201C%s\u201D"; Seems this string is still used somewhere. Does its case still make sense?
Devin Rousso
Comment 3 2020-04-02 16:56:21 PDT
Comment on attachment 395193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395193&action=review >> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:454 >> localizedStrings["Edit \u201C%s\u201D"] = "Edit \u201C%s\u201D"; > > Seems this string is still used somewhere. Does its case still make sense? Actually, it isn't 😅 I had an out-of-date localizedStrings.js.
Devin Rousso
Comment 4 2020-04-02 16:57:09 PDT
Created attachment 395325 [details] Patch
EWS
Comment 5 2020-04-02 18:24:53 PDT
Committed r259437: <https://trac.webkit.org/changeset/259437> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395325 [details].
Radar WebKit Bug Importer
Comment 6 2020-04-02 18:25:15 PDT
<rdar://problem/61236498>
Note You need to log in before you can comment on or make changes to this bug.