Bug 209844

Summary:

TestOptions::enableUndoManagerAPI can be removed

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

HTML Editing

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

wenson_hsieh

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1	none

Description David Kilzer (:ddkilzer) 2020-03-31 18:46:23 PDT

TestOptions::enableUndoManagerAPI can be removed because using "internal:UndoManagerAPIEnabled" will just work:

-<!DOCTYPE html> <!-- webkit-test-runner [ enableUndoManagerAPI=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ internal:UndoManagerAPIEnabled=true ] -->

Comment 1 David Kilzer (:ddkilzer) 2020-03-31 18:48:57 PDT

Created attachment 395120 [details]
Patch v1

Comment 2 David Kilzer (:ddkilzer) 2020-03-31 19:05:17 PDT

Comment on attachment 395120 [details]
Patch v1

Hmmm, I may have underestimated what the fix in Bug 209678 does.  Testing locally, this actually doesn't work by itself.  I cleared the review flag for now.

Comment 3 David Kilzer (:ddkilzer) 2020-03-31 20:21:00 PDT

Welp, it turns out this depends on changes in Bug 209678, so duping to that.

*** This bug has been marked as a duplicate of bug 209678 ***