Bug 209837

Summary:

[ Mojave wk1 Release ] fast/canvas/webgl/texImage2D-mse-flipY-true.html is timing out.

Product:

WebKit

Reporter:

Jason Lawrence <Lawrence.j>

Component:

WebGL

Assignee:

Kenneth Russell <kbr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, dino, jdarpinian, jer.noble, kbr, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Mac

OS:

macOS 10.14

See Also:

https://bugs.webkit.org/show_bug.cgi?id=205734
https://bugs.webkit.org/show_bug.cgi?id=209098

Bug Depends on:

205734

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Jason Lawrence

Reported 2020-03-31 15:55:17 PDT

fast/canvas/webgl/texImage2D-mse-flipY-true.html Description: This test is flaky timing out on Mojave wk1 Release. The current batch of flaky timeouts, which appeared in the visible history after the test was passing consistently, appears to have started on 3/23/2020. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fcanvas%2Fwebgl%2FtexImage2D-mse-flipY-true.html&flavor=wk1&platform=mac&version_name=Mojave&limit=50000&style=release Diff: Not available.

Attachments
Patch (1.61 KB, patch) 2020-05-08 15:04 PDT, Kenneth Russell	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-03-31 15:55:35 PDT

<rdar://problem/61128322>

Jason Lawrence

Comment 2 2020-03-31 16:04:15 PDT

I have marked this test as timing out while this issue is investigated. https://trac.webkit.org/changeset/259319/webkit

Jason Lawrence

Comment 3 2020-03-31 16:11:00 PDT

I was able to reproduce this issue with r259310 by running the command below. run-webkit-tests --iterations 1000 --exit-after-n-failures 3 --child-processes 100 fast/canvas/webgl/texImage2D-mse-flipY-true.html [145/1000] fast/canvas/webgl/texImage2D-mse-flipY-true.html failed unexpectedly (text diff) [231/1000] fast/canvas/webgl/texImage2D-mse-flipY-true.html failed unexpectedly (test timed out, test was not run) [231/1000] fast/canvas/webgl/texImage2D-mse-flipY-true.html failed unexpectedly (test timed out, test was not run)

Kenneth Russell

Comment 4 2020-04-01 20:54:30 PDT

Is there an approximate regression range? Aside from the recent fix for related tests in Issue 205734, the last WebGL validation change was in Issue 209098 and that was on 3/27/2020.

Jer Noble

Comment 5 2020-04-30 14:45:22 PDT

This test has been flakily timing out on this bot since at least 1/23/2020. So if there was a regression, it wasn't super recent.

Jer Noble

Comment 6 2020-04-30 14:46:55 PDT

Also, it has been generating between 1 and 10 flakes per day, starting on 3/24/2020, but has stopped flaking altogether as of 4/7, except for a single flake on 4/28.

Kenneth Russell

Comment 7 2020-05-01 13:30:18 PDT

Good to hear that the flakes stopped recently. The fix in Bug 205734 should have made this test reliably, but that was done before these flakes started. How should this bug be handled at this point? Would it be appropriate to remove the Timeout suppression and close it as WontFix?

Kenneth Russell

Comment 8 2020-05-08 15:04:41 PDT

Created attachment 398894 [details] Patch

Kenneth Russell

Comment 9 2020-05-08 15:05:28 PDT

Looking at the layout test results, a timeout hasn't happened in over a month, so let's remove the suppression and close this.

EWS

Comment 10 2020-05-09 17:02:04 PDT

Committed r261445: <https://trac.webkit.org/changeset/261445> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398894 [details].

Note You need to log in before you can comment on or make changes to this bug.