Bug 209837

Summary: [ Mojave wk1 Release ] fast/canvas/webgl/texImage2D-mse-flipY-true.html is timing out.
Product: WebKit Reporter: Jason Lawrence <Lawrence.j>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dino, jdarpinian, jer.noble, kbr, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac   
OS: macOS 10.14   
See Also: https://bugs.webkit.org/show_bug.cgi?id=205734
https://bugs.webkit.org/show_bug.cgi?id=209098
Bug Depends on: 205734    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Jason Lawrence 2020-03-31 15:55:17 PDT 
fast/canvas/webgl/texImage2D-mse-flipY-true.html

Description:
This test is flaky timing out on Mojave wk1 Release. The current batch of flaky timeouts, which appeared in the visible history after the test was passing consistently, appears to have started on 3/23/2020.

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fcanvas%2Fwebgl%2FtexImage2D-mse-flipY-true.html&flavor=wk1&platform=mac&version_name=Mojave&limit=50000&style=release

Diff:
Not available.
Comment 1 Radar WebKit Bug Importer 2020-03-31 15:55:35 PDT 
<rdar://problem/61128322>
Comment 2 Jason Lawrence 2020-03-31 16:04:15 PDT 
I have marked this test as timing out while this issue is investigated.
https://trac.webkit.org/changeset/259319/webkit
Comment 3 Jason Lawrence 2020-03-31 16:11:00 PDT 
I was able to reproduce this issue with r259310 by running the command below.

run-webkit-tests --iterations 1000 --exit-after-n-failures 3 --child-processes 100 fast/canvas/webgl/texImage2D-mse-flipY-true.html

[145/1000] fast/canvas/webgl/texImage2D-mse-flipY-true.html failed unexpectedly (text diff)
[231/1000] fast/canvas/webgl/texImage2D-mse-flipY-true.html failed unexpectedly (test timed out, test was not run)
[231/1000] fast/canvas/webgl/texImage2D-mse-flipY-true.html failed unexpectedly (test timed out, test was not run)
Comment 4 Kenneth Russell 2020-04-01 20:54:30 PDT 
Is there an approximate regression range? Aside from the recent fix for related tests in Issue 205734, the last WebGL validation change was in Issue 209098 and that was on 3/27/2020.
Comment 5 Jer Noble 2020-04-30 14:45:22 PDT 
This test has been flakily timing out on this bot since at least 1/23/2020.  So if there was a regression, it wasn't super recent.
Comment 6 Jer Noble 2020-04-30 14:46:55 PDT 
Also, it has been generating between 1 and 10 flakes per day, starting on 3/24/2020, but has stopped flaking altogether as of 4/7, except for a single flake on 4/28.
Comment 7 Kenneth Russell 2020-05-01 13:30:18 PDT 
Good to hear that the flakes stopped recently. The fix in Bug 205734 should have made this test reliably, but that was done before these flakes started.

How should this bug be handled at this point? Would it be appropriate to remove the Timeout suppression and close it as WontFix?
Comment 8 Kenneth Russell 2020-05-08 15:04:41 PDT 
Created attachment 398894 [details]
Patch
Comment 9 Kenneth Russell 2020-05-08 15:05:28 PDT 
Looking at the layout test results, a timeout hasn't happened in over a month, so let's remove the suppression and close this.
Comment 10 EWS 2020-05-09 17:02:04 PDT 
Committed r261445: <https://trac.webkit.org/changeset/261445>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398894 [details].