| Summary: | CRASH in MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer(), uncaught ObjC exception | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | calvaris, darin, eric.carlson, ews-watchlist, glenn, mkwst, peng.liu6, philipj, sergio, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jer Noble
2020-03-31 12:41:39 PDT
Created attachment 395081 [details]
Patch
Comment on attachment 395081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395081&action=review > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:903 > + ASSERT_NOT_REACHED(); I don’t really like using assertions like this. As a project we intend to use assertions for things that must *never* happen, not for things that *normally* don’t happen. The other cases in this patch seem to be truly "should never happen" cases, although I might be wrong about that. Comment on attachment 395081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395081&action=review >> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:903 >> + ASSERT_NOT_REACHED(); > > I don’t really like using assertions like this. As a project we intend to use assertions for things that must *never* happen, not for things that *normally* don’t happen. > > The other cases in this patch seem to be truly "should never happen" cases, although I might be wrong about that. My goal here is to catch this case in layout tests; this scenario could easily cause layout test flakiness in a totally un-diagnosable way. If we upgrade a bot to a new OS and this ASSERTion starts getting hit and generates crashlogs, we can immediately trace the cause to a particular OS revision. But maybe we can achieve this some other way, like through a WKTR or DRT only console log that would show up in the test .diff? (In reply to Jer Noble from comment #5) > My goal here is to catch this case in layout tests Got it! > But maybe we can achieve this some other way, like through a WKTR or DRT only console log that would show up in the test .diff? Yes, I think there is quite a bit of logging that shows up in regression test results. Let's check on that. Created attachment 395117 [details]
Patch for landing
Created attachment 395191 [details]
Patch for landing
Committed r259363: <https://trac.webkit.org/changeset/259363> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395191 [details]. |