Bug 209813

Summary:

Remove <br> render tree dump quirk

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, clopez, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jbedard, jer.noble, jlewis3, kondapallykalyan, pdr, philipj, rackler, ryanhaddad, sergio, simon.fraser, tsavell, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
wip	none
plain patch without rebasing	zalan: review+, ews-feeder: commit-queue-
generate all test results	ews-feeder: commit-queue-
for bots	none
for bots	ews-feeder: commit-queue-
for bots	ews-feeder: commit-queue-
for bots	none
patch	none

Description Antti Koivisto 2020-03-31 09:16:41 PDT

Stop lying about <br> size and position in render tree dumps.

Comment 1 Antti Koivisto 2020-03-31 10:00:08 PDT

Created attachment 395056 [details]
wip

Comment 2 zalan 2020-03-31 10:01:34 PDT

so much bravery here

Comment 3 Antti Koivisto 2020-09-29 05:38:35 PDT

Created attachment 409987 [details]
plain patch without rebasing

Comment 4 Antti Koivisto 2020-09-29 09:04:43 PDT

This will require lots of rebasing to land.

Comment 5 Antti Koivisto 2020-10-14 08:03:43 PDT

Created attachment 411323 [details]
generate all test results

Comment 6 Jonathan Bedard 2020-10-14 09:10:46 PDT

Let's include bot watchers on this one, this sort of change makes bisection difficult.

Comment 7 Antti Koivisto 2020-10-14 09:31:17 PDT

Created attachment 411332 [details]
for bots

Comment 8 Antti Koivisto 2020-10-14 10:26:03 PDT

Created attachment 411346 [details]
for bots

Comment 9 Antti Koivisto 2020-10-15 00:08:28 PDT

Created attachment 411413 [details]
for bots

Comment 10 Antti Koivisto 2020-10-15 01:35:24 PDT

Created attachment 411418 [details]
for bots

Comment 11 Antti Koivisto 2020-10-15 02:58:52 PDT

Created attachment 411420 [details]
patch

Comment 12 EWS 2020-10-15 04:32:45 PDT

Committed r268520: <https://trac.webkit.org/changeset/268520>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411420 [details].

Comment 13 Radar WebKit Bug Importer 2020-10-15 04:33:20 PDT

<rdar://problem/70331086>

Comment 14 Antti Koivisto 2020-10-15 04:45:48 PDT

Botwatchers, any fallout from this can be handled by rebasing.

Comment 15 Truitt Savell 2020-10-15 15:00:31 PDT

Rebaslined tests for Catalina in: https://trac.webkit.org/changeset/268556/webkit

Comment 16 Carlos Alberto Lopez Perez 2020-10-15 18:31:48 PDT

Rebaselined tests for GTK in r268545 and for WPE in r268568

Comment 17 Truitt Savell 2020-10-16 16:50:27 PDT

Rebaslined tests for Big Sur https://trac.webkit.org/changeset/268620/webkit

Comment 18 Ryan Haddad 2020-10-16 18:04:33 PDT

Reverted r268620 for reason:

Breaks tests for Catalina and Mojave

Committed r268625: <https://trac.webkit.org/changeset/268625>

Comment 19 Darin Adler 2020-10-18 16:43:59 PDT

When I run tests locally, I see failures that seem to be related to this. So it seems like we haven’t done enough rebasing yet.

Here are some tests that are failing locally for me due to <br> geometry differences:

editing/selection/3690703-2.html
editing/selection/3690703.html
editing/selection/3690719.html
fast/css/rtl-ordering.html
fast/forms/input-appearance-spinbutton.html

There are probably more; these are mixed in with failures caused by the code I am working on. I am running modern WebKit tests on a Mac running macOS Big Sur.

Comment 20 Karl Rackler 2020-10-20 18:07:20 PDT

Re-baseline test for Big Sur after the changes in r268750
https://trac.webkit.org/changeset/268777/webkit