Bug 209759

Summary: REGRESSION (r259211): ASSERT(window) in applicationType() under shouldUseForegroundPriorityForClientNavigation()
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, darin, ggaren, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=209748
https://bugs.webkit.org/show_bug.cgi?id=207341
Bug Depends on:    
Bug Blocks: 209748    
Attachments:
Description Flags
Patch none

Description Tim Horton 2020-03-30 12:35:40 PDT 
#1	0x00000001003ee42b in WTFCrashWithInfo(int, char const*, char const*, int)
#2	0x0000000100c5dbed in WebKit::applicationType(UIWindow*)
#3	0x0000000101129a41 in WebKit::PageClientImpl::isApplicationVisible()
#4	0x00000001011abfe6 in WebKit::WebPageProxy::shouldUseForegroundPriorityForClientNavigation() const
#5	0x0000000100fb52f5 in WebKit::WebPageProxy::loadRequest(WebCore::ResourceRequest&&, WebCore::ShouldOpenExternalURLsPolicy, API::Object*)
#6	0x0000000100cdcc2d in -[WKWebView loadRequest:]


shouldUseForegroundPriorityForClientNavigation() calls isApplicationVisible() when a view is unparented, but isApplicationVisible() depends on having a window to determine the type of application.
Comment 1 Chris Dumez 2020-03-30 15:53:51 PDT 
Created attachment 394976 [details]
Patch
Comment 2 EWS 2020-03-30 16:41:43 PDT 
Committed r259242: <https://trac.webkit.org/changeset/259242>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394976 [details].
Comment 3 Radar WebKit Bug Importer 2020-03-30 16:42:16 PDT 
<rdar://problem/61079983>