| Summary: | ScrollLatchingState should use WeakPtr<Element> | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cmarcelo, darin, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2020-03-28 20:20:47 PDT
Created attachment 394856 [details]
Patch
Comment on attachment 394856 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394856&action=review > Source/WebCore/page/scrolling/ScrollLatchingState.h:48 > + void setWheelEventElement(Element*); Does this need to accept null? Could it take a references instead of a pointer? > Source/WebCore/page/scrolling/ScrollLatchingState.h:57 > + void setPreviousWheelScrolledElement(Element*); Ditto. > Source/WebCore/page/scrolling/ScrollLatchingState.h:61 > + Ditto. |