Bug 209711

Summary: REGRESSION (r258201): Use-after-move in UserMediaCaptureManager::Source::didFail()
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Service WorkersAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2020-03-28 19:19:42 PDT
Use-after-move in UserMediaCaptureManager::Source::didFail() of `errorMessage`: void didFail(String&& errorMessage) { m_isReady = true; m_errorMessage = WTFMove(errorMessage); if (m_callback) m_callback(String(errorMessage)); } This regressed in: Bug 208816: Remove sync IPC when creating a remote capture source <https://bugs.webkit.org/show_bug.cgi?id=208816> <rdar://problem/60270112> <https://trac.webkit.org/changeset/258201>
Attachments
Patch v1 (1.39 KB, patch)
2020-03-28 19:23 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-03-28 19:20:06 PDT
<rdar://problem/61018569>
David Kilzer (:ddkilzer)
Comment 2 2020-03-28 19:23:19 PDT
Created attachment 394850 [details] Patch v1
EWS
Comment 3 2020-03-28 20:03:04 PDT
Committed r259172: <https://trac.webkit.org/changeset/259172> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394850 [details].
Note You need to log in before you can comment on or make changes to this bug.