| Summary: | [RenderTreeBuilder] Destroy the child first in RenderTreeBuilder::destroyAndCleanUpAnonymousWrappers | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=207034 | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2020-03-27 20:49:27 PDT
Created attachment 394786 [details]
Patch
If this is the order we want we should probably change RenderTreeBuilder::destroy instead. (In reply to Antti Koivisto from comment #2) > If this is the order we want we should probably change > RenderTreeBuilder::destroy instead. Yeah, that's a good point. I would guess the ::destroy() is only called with the bottom-most renderer from the updater, and only the builder calls it with depth (in case of anon wrappers). (In reply to zalan from comment #3) > (In reply to Antti Koivisto from comment #2) > > If this is the order we want we should probably change > > RenderTreeBuilder::destroy instead. > Yeah, that's a good point. I would guess the ::destroy() is only called with > the bottom-most renderer from the updater, and only the builder calls it > with depth (in case of anon wrappers). Actually we tried that here https://trac.webkit.org/changeset/228606/webkit and had to revert. Created attachment 394825 [details]
Patch
Committed r259160: <https://trac.webkit.org/changeset/259160> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394825 [details]. |