| Summary: | Skip stress/test-out-of-memory.js on memory limited devices. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | keith_miller, ticaiolima, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Mark Lam
2020-03-27 17:37:55 PDT
Created attachment 394773 [details]
proposed patch.
Comment on attachment 394773 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=394773&action=review > JSTests/stress/test-out-of-memory.js:1 > +//@ skip if $memoryLimited or ["arm", "mips"].include?($architecture) I think $memoryLimited is a superset of "arm"/"mips"? (In reply to Keith Miller from comment #2) > Comment on attachment 394773 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394773&action=review > > > JSTests/stress/test-out-of-memory.js:1 > > +//@ skip if $memoryLimited or ["arm", "mips"].include?($architecture) > > I think $memoryLimited is a superset of "arm"/"mips"? I think you're right, but I don't see code that confirms this for sure. This change is conservative. I would like to land it to green a bot, and I'll ping the arm/mips guys to remove the condition if it is indeed unnecessary. Comment on attachment 394773 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=394773&action=review r=me. >>> JSTests/stress/test-out-of-memory.js:1 >>> +//@ skip if $memoryLimited or ["arm", "mips"].include?($architecture) >> >> I think $memoryLimited is a superset of "arm"/"mips"? > > I think you're right, but I don't see code that confirms this for sure. This change is conservative. I would like to land it to green a bot, and I'll ping the arm/mips guys to remove the condition if it is indeed unnecessary. sounds good. Can you make sure to ping them? Thanks. Landed in r259149: <http://trac.webkit.org/r259149>. Comment on attachment 394773 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=394773&action=review >>>> JSTests/stress/test-out-of-memory.js:1 >>>> +//@ skip if $memoryLimited or ["arm", "mips"].include?($architecture) >>> >>> I think $memoryLimited is a superset of "arm"/"mips"? >> >> I think you're right, but I don't see code that confirms this for sure. This change is conservative. I would like to land it to green a bot, and I'll ping the arm/mips guys to remove the condition if it is indeed unnecessary. > > sounds good. Can you make sure to ping them? Just for the record, `$memoryLimited` and `$architecture == "arm" or "mips"`are note related each other. However, we use `--memory-limited` to run stress tests in all bots for ARMv7 and MIPS. Since it is defined in bots configuration, I'm afraid we won't find any relationship of them on WebKit tree. I think it is fine to have a mental model that `$memoryLimited is a superset of "arm"/"mips"` now, but It can change in the future. |