Bug 209683

Summary:

Delete code for security EWS from old EWS

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, ews-watchlist, glenn, jbedard, kocsen_chung, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2020-03-27 15:14:14 PDT

Old EWS has been deprecated. All the queues have been moved to new EWS.

We should delete the code which was added to support security bugs in old EWS. New EWS implements security EWS in completely different manner.

Comment 1 Aakash Jain 2020-03-27 15:20:42 PDT

Created attachment 394764 [details]
Patch

Comment 2 Aakash Jain 2020-03-27 15:24:22 PDT

(In reply to Aakash Jain from comment #1)
> Created attachment 394764 [details]
This reverts r232979, r233061, r233190, r233219, r233276 and r233288. It also take cares of maintaining Python 3 support (e.g. retaining changes from r251374).

Comment 3 Kocsen Chung 2020-03-27 16:08:17 PDT

Comment on attachment 394764 [details]
Patch

Looks good to me.

Comment 4 Jonathan Bedard 2020-03-30 08:48:58 PDT

This is a really difficult patch to review, not because it's bad code, but because it's reverting code that is unfortunately coupled tightly with code that we still need.

I'm going to Rubber-stamp it because it's passed tests and, as far as I can tell, does what it claims to. Difficult for me to be certain about that, though, this isn't code I'm very familiar with.

Comment 5 Jonathan Bedard 2020-03-30 08:49:05 PDT

rs=me

Comment 6 Aakash Jain 2020-03-30 11:26:06 PDT

Committed r259212: <https://trac.webkit.org/changeset/259212>

Comment 7 Radar WebKit Bug Importer 2020-03-30 11:27:12 PDT

<rdar://problem/61064617>

Comment 8 Aakash Jain 2020-03-31 09:54:14 PDT

Committed r259295 <https://trac.webkit.org/changeset/259295> (which reverts r233220).