Bug 209672

Summary:	[ Mac wk2 ] ASSERTION FAILED: m_messageEventCount @ WebCore::ServiceWorkerThread::finishedFiringMessageEvent()
Product:	WebKit	Reporter:	Jason Lawrence <Lawrence.j>
Component:	Service Workers	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED CONFIGURATION CHANGED
Severity:	Normal	CC:	cdumez, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Mac
OS:	macOS 10.15

Description Jason Lawrence 2020-03-27 12:07:19 PDT

http/wpt/service-workers/service-worker-spinning-fetch.https.html

Description:
This test is flaky failing and crashing on Mac wk2. The flaky failures and crashes appear throughout the visible history, but are rather light in some areas.

History:
https://results.webkit.org/?suite=layout-tests&test=http%2Fwpt%2Fservice-workers%2Fservice-worker-spinning-fetch.https.html&platform=mac&limit=50000

Diff:
--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/wpt/service-workers/service-worker-spinning-fetch.https-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/wpt/service-workers/service-worker-spinning-fetch.https-actual.txt
@@ -1,5 +1,5 @@
 
 
 PASS Spin in fetch 
-PASS Spin after fetch 
+FAIL Spin after fetch promise_test: Unhandled rejection with value: "service worker is still running"
 


stderr:
ASSERTION FAILED: m_messageEventCount
./workers/service/context/ServiceWorkerThread.cpp(296) : void WebCore::ServiceWorkerThread::finishedFiringMessageEvent()
1   0x781b987b9 WTFCrash
2   0x76505744b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x76990f3cc WebCore::ServiceWorkerThread::finishedFiringMessageEvent()
4   0x769946000 WebCore::ServiceWorkerThread::queueTaskToPostMessage(WebCore::MessageWithMessagePorts&&, WTF::Variant<WebCore::ServiceWorkerData, WebCore::ServiceWorkerClientData>&&)::$_23::operator()()::'lambda'()::operator()() const
5   0x769945f89 WTF::Detail::CallableWrapper<WebCore::ServiceWorkerThread::queueTaskToPostMessage(WebCore::MessageWithMessagePorts&&, WTF::Variant<WebCore::ServiceWorkerData, WebCore::ServiceWorkerClientData>&&)::$_23::operator()()::'lambda'(), void>::call()
6   0x781bc316a WTF::Function<void ()>::operator()() const
7   0x781c0267b WTF::dispatchFunctionsFromMainThread()
8   0x781c05775 -[JSWTFMainThreadCaller call]
9   0x7fff43ea1742 __NSThreadPerformPerform
10  0x7fff41bc6683 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
11  0x7fff41bc6629 __CFRunLoopDoSource0
12  0x7fff41ba9feb __CFRunLoopDoSources0
13  0x7fff41ba95b5 __CFRunLoopRun
14  0x7fff41ba8ebe CFRunLoopRunSpecific
15  0x7fff43e0d7df -[NSRunLoop(NSRunLoop) runMode:beforeDate:]
16  0x7fff43e0d6b4 -[NSRunLoop(NSRunLoop) run]
17  0x7fff6dd38077 _xpc_objc_main
18  0x7fff6dd37b79 _xpc_copy_xpcservice_dictionary
19  0x7588a5958 WebKit::XPCServiceMain(int, char const**)
20  0x759c1aa4b WKXPCServiceMain
21  0x108c58ea2 main
22  0x7fff6daff3d5 start
23  0x1
LEAK: 1 WebPageProxy
LEAK: 1 WebPage
LEAK: 2 WebFrame
LEAK: 9 RenderObject
LEAK: 12 BidiRun
LEAK: 1 Page
LEAK: 2 Frame
LEAK: 20 CachedResource
LEAK: 29 WebCoreNode

Comment 1 Radar WebKit Bug Importer 2020-03-27 12:07:43 PDT

<rdar://problem/60978663>

Comment 2 Jason Lawrence 2020-03-27 12:12:39 PDT

I have marked this test as failing and crashing while this issue is investigated.
https://trac.webkit.org/changeset/259132/webkit

Comment 3 Jason Lawrence 2020-03-27 12:16:27 PDT

I can reproduce the failures with r259121 and the command below.
run-webkit-tests --iterations 1000 --force -f --exit-after-n-failures 3 http/wpt/service-workers/service-worker-spinning-fetch.https.html

[75/1000] http/wpt/service-workers/service-worker-spinning-fetch.https.html failed unexpectedly (text diff)
[202/1000] http/wpt/service-workers/service-worker-spinning-fetch.https.html failed unexpectedly (text diff)

Comment 4 youenn fablet 2020-06-17 05:18:20 PDT

Reverted test expectation in https://trac.webkit.org/changeset/262409