Bug 209656

Summary: <button> should support display:inline-grid/grid/inline-flex/flex correctly
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Layout and RenderingAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: agafvv, anthony.liatsis, bfulgham, cdumez, changseok, clopez, esprehn+autocc, ews-watchlist, gyuyoung.kim, jfernandez, mark.lam, mattiasha, m.kurz+webkitbugs, rego, sam, simon.fraser, svillar, victorortegadgg, webkit-bug-importer, ysuzuki, zalan
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=700029
Attachments:
Description Flags
Patch jfernandez: review+

Description Carlos Alberto Lopez Perez 2020-03-27 09:12:40 PDT 
It seems WebKit its not following the spec https://html.spec.whatwg.org/multipage/rendering.html#button-layout regarding <butoon> elements when computing the value of 'display' property for the cases of 'inline-grid', 'grid', 'inline-flex', or 'flex',

This is covered (at least) by WPT tests css/css-grid/grid-model/grid-button-001.html and html/rendering/widgets/button-layout/grid.html

Run this tests live:
https://wpt.live/css/css-grid/grid-model/grid-button-001.html
https://wpt.live/html/rendering/widgets/button-layout/grid.html

There is also a manual test on

A similar issue (if not the same) has been reported and fixed in Chromium recently. Check: https://bugs.chromium.org/p/chromium/issues/detail?id=700029
Check also the test case from that Chromium bug: http://jsbin.com/lenupa/1/edit?html,css,output (the text inside the button element should NOT be vertically centered)
Comment 1 Carlos Alberto Lopez Perez 2020-03-27 09:16:25 PDT 
Also covered by WPT test html/rendering/widgets/button-layout/flex.html

https://wpt.live/html/rendering/widgets/button-layout/flex.html
Comment 2 Manuel Rego Casasnovas 2020-05-21 06:31:00 PDT 
I think this is a duplicate of bug #127247.
Comment 3 Carlos Alberto Lopez Perez 2020-05-21 06:44:36 PDT 
*** Bug 212206 has been marked as a duplicate of this bug. ***
Comment 4 Carlos Alberto Lopez Perez 2020-05-21 06:48:14 PDT 
(In reply to Manuel Rego Casasnovas from comment #2)
> I think this is a duplicate of bug #127247.

Likely. But I will mark the other as duplicate of this, since this bug report (even when newer) has more info about the problem.
Comment 5 Carlos Alberto Lopez Perez 2020-05-21 06:49:51 PDT 
*** Bug 127247 has been marked as a duplicate of this bug. ***
Comment 6 Sergio Villar Senin 2020-08-18 03:15:29 PDT 
Created attachment 406776 [details]
Patch
Comment 7 Sergio Villar Senin 2020-08-19 06:33:47 PDT 
Committed r265851: <https://trac.webkit.org/changeset/265851>
Comment 8 Radar WebKit Bug Importer 2020-08-19 06:34:16 PDT 
<rdar://problem/67400123>