Bug 209651

Summary: [css-grid][css-flexbox] WPT tests for computed style for auto minimum size fail
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: CSSAssignee: Oriol Brufau <obrufau>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jfernandez, macpherson, menard, obrufau, rego, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=682869
Attachments:
Description Flags
Patch
none
Patch none

Comment 1 Carlos Alberto Lopez Perez 2020-04-13 20:46:43 PDT 
The WPT flexbox test which was added to WPT on the same Chromium bug from above also fails on WebKit

http://wpt.live/css/css-flexbox/getcomputedstyle/flexbox_computedstyle_min-auto-size.html

So its likely the same issue or very related
Comment 2 Oriol Brufau 2020-05-20 12:59:40 PDT 
Created attachment 399880 [details]
Patch
Comment 3 Manuel Rego Casasnovas 2020-05-20 13:04:26 PDT 
Comment on attachment 399880 [details]
Patch

Thanks for the fix. r=me
Comment 4 Manuel Rego Casasnovas 2020-05-20 13:06:20 PDT 
Comment on attachment 399880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399880&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/getcomputedstyle/flexbox_computedstyle_min-auto-size.html:1
> +<!DOCTYPE html>

Mmm, shouldn't this new test appear in some w3c-import.log file?
Comment 5 Manuel Rego Casasnovas 2020-05-20 13:09:01 PDT 
(In reply to Manuel Rego Casasnovas from comment #4)
> Comment on attachment 399880 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399880&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/getcomputedstyle/flexbox_computedstyle_min-auto-size.html:1
> > +<!DOCTYPE html>
> 
> Mmm, shouldn't this new test appear in some w3c-import.log file?

Actually this test is already imported... I guess you need to update your trunk and rebase this patch.
Comment 6 Oriol Brufau 2020-05-20 13:39:23 PDT 
Created attachment 399884 [details]
Patch
Comment 7 Oriol Brufau 2020-05-20 13:40:40 PDT 
Comment on attachment 399884 [details]
Patch

Thanks, rebased the patch.
Comment 8 EWS 2020-05-20 17:12:50 PDT 
Committed r261974: <https://trac.webkit.org/changeset/261974>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399884 [details].
Comment 9 Radar WebKit Bug Importer 2020-05-20 17:13:18 PDT 
<rdar://problem/63470417>