Bug 209648

Summary: [Flatpak SDK] build-webkit --flatpak-cmakeargs option is ignored
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Tools / TestsAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, clopez, tsaunier, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Philippe Normand
Reported 2020-03-27 03:34:22 PDT
Because build-webkit spawns webkit-flatpak --command="build-webkit ..." instead of webkit-flatpak -b. I'm not sure this -b makes much sense anymore.
Attachments
Patch (14.32 KB, patch)
2020-04-01 08:43 PDT, Philippe Normand 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-03-27 03:40:02 PDT
Generally speaking, I think webkit-flatpak has too many, redundant, options... Maybe we can remove most of those? For instance, --tests doesn't seem necessary as we should use run-webkit-tests directly. Dunno. Just some thoughts :)
Philippe Normand
Comment 2 2020-04-01 08:43:25 PDT
Created attachment 395170 [details] Patch
Carlos Alberto Lopez Perez
Comment 3 2020-04-01 09:44:24 PDT
Speaking for myself I use none of those.. I run the scripts (run-minibrowser, run-webkit-tests, etc) directly and I expect those scripts to work automatically with flatpak if I have previously built the third-party libraries with flatpak. But I don't know if somebody else uses this :?
Philippe Normand
Comment 4 2020-04-01 09:54:22 PDT
To my knowledge Thibault was the only one using webkit-flatpak directly. I use it occasionally but only to get in the sandbox or run gdb. I also use the existing scripts whenever possible.
Adrian Perez
Comment 5 2020-04-01 14:30:06 PDT
(In reply to Philippe Normand from comment #4) > To my knowledge Thibault was the only one using webkit-flatpak directly. I > use it occasionally but only to get in the sandbox or run gdb. I also use > the existing scripts whenever possible. I have used “webkit-flatpak” directly sometimes, most of the time it's nicer to use the existing scripts, but having the escape hatch to do things “by hand” with the Flatpak environment is handy — the same way as having the “jhbuild-wrapper” script has been useful sometimes.
Philippe Normand
Comment 6 2020-04-02 01:45:50 PDT
Which webkit-flatpak options do you use? This patch doesn't remove all of them :)
Philippe Normand
Comment 7 2020-04-03 02:21:34 PDT
Committed r259451: <https://trac.webkit.org/changeset/259451>
Radar WebKit Bug Importer
Comment 8 2020-04-03 02:22:13 PDT
<rdar://problem/61251129>
Note You need to log in before you can comment on or make changes to this bug.