Bug 209644

Summary: Deduplicate WebsiteDataStore::parameters() of Cocoa port and non-Cocoa port
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: WebKit2Assignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, webkit-bug-importer, wilander, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=209410
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Fujii Hironori 2020-03-27 01:02:13 PDT 
[WinCairo] ASSERT(m_resourceLoadStatistics) is failing setThirdPartyCookieBlockingMode

WinCairo WTR is still failing the assertion even after r259076 which fixed the same assertion failure.

WinCairo, debug builds, trunk@259081

fast/dom/window-open-ephemeral.html
http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html
http/tests/cache/disk-cache/disk-cache-vary-cookie-private.html
http/tests/security/cookies/third-party-cookie-blocking-redirect.html
http/tests/security/cookies/third-party-cookie-blocking-user-action.html
http/tests/security/cookies/third-party-cookie-blocking.html
storage/indexeddb/aborted-versionchange-closes-private.html
storage/indexeddb/basics-private.html
storage/indexeddb/clone-exception-private.html
storage/indexeddb/closed-cursor-private.html
storage/indexeddb/connection-leak-private.html


> ASSERTION FAILED: m_resourceLoadStatistics
> ..\..\Source\WebKit\NetworkProcess/NetworkSession.cpp(248) : setThirdPartyCookieBlockingMode
> 1   00007FF926951429 WTFCrash
> 2   00007FF919A21F50 WTFCrashWithInfo
> 3   00007FF91D8B74FD WebKit::NetworkSession::setThirdPartyCookieBlockingMode
> 4   00007FF91D819878 WebKit::NetworkProcess::setShouldBlockThirdPartyCookiesForTesting
> 5   00007FF91D4986A4 IPC::callMemberFunctionImpl<WebKit::NetworkProcess,void (WebKit::NetworkProcess::*)(PAL::SessionID, WebCore::ThirdPartyCookieBlockingMode, WTF::CompletionHandler<void ()> &&),void (),std::tuple<PAL::SessionID,WebCore::ThirdPartyCookieBlockingMode>,0,1>
> 6   00007FF91D496A14 IPC::callMemberFunction<WebKit::NetworkProcess,void (WebKit::NetworkProcess::*)(PAL::SessionID, WebCore::ThirdPartyCookieBlockingMode, WTF::CompletionHandler<void ()> &&),void (),std::tuple<PAL::SessionID,WebCore::ThirdPartyCookieBlockingMode>,std::integer_sequence<unsigned long long,0,1> >
> 7   00007FF91D432B33 IPC::handleMessageAsync<Messages::NetworkProcess::SetShouldBlockThirdPartyCookiesForTesting,WebKit::NetworkProcess,void (WebKit::NetworkProcess::*)(PAL::SessionID, WebCore::ThirdPartyCookieBlockingMode, WTF::CompletionHandler<void ()> &&)>
> 8   00007FF91D427021 WebKit::NetworkProcess::didReceiveNetworkProcessMessage
> 9   00007FF91D81278C WebKit::NetworkProcess::didReceiveMessage
> 10  00007FF91DA3B9F6 IPC::Connection::dispatchMessage
> 11  00007FF91DA3C0DB IPC::Connection::dispatchMessage
> 12  00007FF91DA3C78B IPC::Connection::dispatchOneIncomingMessage
> 13  00007FF91DA3F50C IPC::Connection::enqueueIncomingMessage::<unnamed-tag>::operator()
> 14  00007FF91DA3F467 WTF::Detail::CallableWrapper<`lambda at ..\..\Source\WebKit\Platform\IPC\Connection.cpp:981:30',void>::call
> 15  00007FF9269645D0 WTF::Function<void ()>::operator()
> 16  00007FF9269C0BBC WTF::RunLoop::performWork
> 17  00007FF926A8D4D5 WTF::RunLoop::wndProc
> 18  00007FF926A8D3E9 WTF::RunLoop::RunLoopWndProc
> 19  00007FF947735C0D CallWindowProcW
> 20  00007FF947735602 DispatchMessageW
> 21  00007FF926A8D6F3 WTF::RunLoop::run
> 22  00007FF91D2DFD8B WebKit::AuxiliaryProcessMain<WebKit::NetworkProcess,WebKit::NetworkProcessMainCurl>
> 23  00007FF91D2DFB1B WebKit::NetworkProcessMain
> 24  00007FF7D6CE101C main
> 25  00007FF7D6CE123C __scrt_common_main_seh
> 26  00007FF948FF7BD4 BaseThreadInitThunk
> 27  00007FF94914CED1 RtlUserThreadStart
> LEAK: 20 WebPageProxy
Comment 1 Fujii Hironori 2020-03-29 23:29:18 PDT 
Created attachment 394889 [details]
Patch
Comment 2 youenn fablet 2020-03-30 05:21:41 PDT 
Comment on attachment 394889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394889&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:2221
> +    };

There is a lot of code shared with WebsiteDataStoreParameters WebsiteDataStore::parameters() in WebsiteDataStoreCocoa.mm.
Can we try sharing it?
GTP seems to have an issue with hasStatisticsTestingCallback.
Comment 3 Fujii Hironori 2020-03-30 17:59:13 PDT 
Comment on attachment 394889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394889&action=review

>> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:2221
>> +    };
> 
> There is a lot of code shared with WebsiteDataStoreParameters WebsiteDataStore::parameters() in WebsiteDataStoreCocoa.mm.
> Can we try sharing it?
> GTP seems to have an issue with hasStatisticsTestingCallback.

Good idea. Will do so.
Comment 4 Fujii Hironori 2020-03-30 19:30:31 PDT 
Created attachment 395005 [details]
Patch
Comment 5 Fujii Hironori 2020-03-30 20:09:43 PDT 
Created attachment 395009 [details]
Patch
Comment 6 Fujii Hironori 2020-03-30 20:56:44 PDT 
Created attachment 395012 [details]
Patch
Comment 7 Fujii Hironori 2020-03-30 21:09:32 PDT 
Created attachment 395013 [details]
Patch
Comment 8 Fujii Hironori 2020-03-30 22:51:26 PDT 
Created attachment 395017 [details]
Patch
Comment 9 Fujii Hironori 2020-03-31 17:05:33 PDT 
Comment on attachment 395017 [details]
Patch

Clearing flags on attachment: 395017

Committed r259323: <https://trac.webkit.org/changeset/259323>
Comment 10 Fujii Hironori 2020-03-31 17:05:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2020-03-31 17:08:47 PDT 
<rdar://problem/61131748>