Bug 209623

Summary: Rename -_isInteractingWithFocusedElement, add it to the header, and replace calls to hasFocusedElement() with it
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2020-03-26 15:20:29 PDT
The code in WKContentViewInteraction.mm uses either [self _isInteractingWithFocusedElement] or hasFocusedElement(_focusedElementInformation) to check if there is a currently focused keyboard-assisted element. The former is just a convenience function for the latter. There is never more than one focused element so hasFocusedElement() is always passed _focusedElementInformation. So, let's remove hasFocusedElement() and standardize on -_isInteractingWithFocusedElement. We might as well consider renaming -_isInteractingWithFocusedElement at the same time.
Attachments
Patch (16.35 KB, patch)
2020-03-26 15:33 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2020-03-26 15:33:39 PDT
Created attachment 394663 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-03-26 15:58:54 PDT
<rdar://problem/60940521>
Daniel Bates
Comment 3 2020-03-26 16:10:40 PDT
Comment on attachment 394663 [details] Patch Clearing flags on attachment: 394663 Committed r259091: <https://trac.webkit.org/changeset/259091>
Daniel Bates
Comment 4 2020-03-26 16:10:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.