Bug 209623

Summary: Rename -_isInteractingWithFocusedElement, add it to the header, and replace calls to hasFocusedElement() with it
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Daniel Bates 2020-03-26 15:20:29 PDT 
The code in WKContentViewInteraction.mm uses either [self _isInteractingWithFocusedElement] or hasFocusedElement(_focusedElementInformation) to check if there is a currently focused keyboard-assisted element. The former is just a convenience function for the latter. There is never more than one focused element so hasFocusedElement() is always passed _focusedElementInformation. So, let's remove hasFocusedElement() and standardize on -_isInteractingWithFocusedElement. We might as well consider renaming -_isInteractingWithFocusedElement at the same time.
Comment 1 Daniel Bates 2020-03-26 15:33:39 PDT 
Created attachment 394663 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-03-26 15:58:54 PDT 
<rdar://problem/60940521>
Comment 3 Daniel Bates 2020-03-26 16:10:40 PDT 
Comment on attachment 394663 [details]
Patch

Clearing flags on attachment: 394663

Committed r259091: <https://trac.webkit.org/changeset/259091>
Comment 4 Daniel Bates 2020-03-26 16:10:41 PDT 
All reviewed patches have been landed.  Closing bug.