Bug 209621

Summary: [ Mac wk1 ] fast/loader/child-frame-add-after-back-forward.html is flaky timing out.
Product: WebKit Reporter: Jason Lawrence <Lawrence.j>
Component: FramesAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, cdumez, ggaren, jbedard, rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac   
OS: macOS 10.14   
Attachments:
Description Flags
Patch none

Jason Lawrence
Reported 2020-03-26 14:41:54 PDT
fast/loader/child-frame-add-after-back-forward.html Description: This test is flaky timing out on Mac wk1. The flaky timeouts are apparent through most of the visible history, with the oldest appearing on 12/31/2019. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Floader%2Fchild-frame-add-after-back-forward.html&platform=mac&flavor=wk1&style=release&style=debug&limit=50000 Diff: --- /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/fast/loader/child-frame-add-after-back-forward-expected.txt +++ /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/fast/loader/child-frame-add-after-back-forward-actual.txt @@ -1,8 +1,5 @@ main frame - has 1 onunload handler(s) -main frame - has 1 onunload handler(s) -Go forward then back. +FAIL: Timed out waiting for notifyDone to be called +This tests the parsing of charset in the meta tag. The following should be a Hebrew word: --------- -Frame: '<!--frame1-->' --------- -PASS +עברית
Attachments
Patch (2.62 KB, patch)
2020-04-02 09:58 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-03-26 14:43:21 PDT
<rdar://problem/60937276>
Jason Lawrence
Comment 2 2020-03-26 14:51:21 PDT
I have marked this test as timing out while this issue is investigated. https://trac.webkit.org/changeset/259082/webkit
Chris Dumez
Comment 3 2020-04-01 15:56:23 PDT
Looks like this could be a test harness issue, not an issue with the test in question. The output seems to be for another test: fast/loader/charset-parse.html Likely the preceding test.
Chris Dumez
Comment 4 2020-04-01 15:58:37 PDT
(In reply to Chris Dumez from comment #3) > Looks like this could be a test harness issue, not an issue with the test in > question. The output seems to be for another test: > fast/loader/charset-parse.html > > Likely the preceding test. Or maybe fast/loader/child-frame-add-after-back-forward.html ends up navigating too far back in some cases (back to the previous test which was loaded in the same view). I think this makes some sense.
Chris Dumez
Comment 5 2020-04-02 09:36:02 PDT
Unable to reproduce so far. If someone is, please let me know how.
Chris Dumez
Comment 6 2020-04-02 09:53:48 PDT
I don't see anything particularly wrong or racy with the test..
Chris Dumez
Comment 7 2020-04-02 09:58:08 PDT
Created attachment 395275 [details] Patch
EWS
Comment 8 2020-04-02 11:12:50 PDT
Committed r259395: <https://trac.webkit.org/changeset/259395> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395275 [details].
Note You need to log in before you can comment on or make changes to this bug.