Bug 209606

Summary:

IndexedDB: destroy WebIDBServer when session is removed in network process

Product:

WebKit

Reporter:

Sihui Liu <sihui_liu>

Component:

New Bugs

Assignee:

Sihui Liu <sihui_liu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alecflett, beidson, benjamin, cdumez, cmarcelo, ews-watchlist, ggaren, jsbell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Sihui Liu 2020-03-26 10:29:05 PDT

Also perform necessary cleanup on WebIDBServer before deleting it.

Comment 1 Sihui Liu 2020-03-26 10:29:38 PDT

<rdar://problem/59310081>

Comment 2 Sihui Liu 2020-03-26 10:40:16 PDT

Created attachment 394624 [details]
Patch

Comment 3 Geoffrey Garen 2020-03-27 09:09:36 PDT

Comment on attachment 394624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394624&action=review

r=me

> Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp:375
> +void WebIDBServer::destroy()

Since this doesn't directly delete the object, I think a name like "close" or "invalidate" would be better.

Comment 4 Sihui Liu 2020-03-31 14:54:20 PDT

Created attachment 395094 [details]
Patch for landing

Comment 5 EWS 2020-03-31 15:19:32 PDT

Committed r259316: <https://trac.webkit.org/changeset/259316>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395094 [details].