| Summary: | [GTK][WPE] REGRESSION(r257775): Media controls current time label changes its size when it's updated | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aperez, bugs-noreply, calvaris, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio | ||||
| Priority: | P2 | Keywords: | Gtk, Regression | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 209591 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Carlos Garcia Campos
2020-03-26 05:46:26 PDT
Created attachment 394597 [details]
Patch
Comment on attachment 394597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394597&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:-224 > -audio::-webkit-media-controls-time-remaining-display.hidden, > -video::-webkit-media-controls-time-remaining-display.hidden { Why do you remove this? (In reply to Xabier Rodríguez Calvar from comment #2) > Comment on attachment 394597 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394597&action=review > > > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:-224 > > -audio::-webkit-media-controls-time-remaining-display.hidden, > > -video::-webkit-media-controls-time-remaining-display.hidden { > > Why do you remove this? Because there isn't any time remaining label. It's a bit unrelated to this patch, I realized working on this, but I can move it to its own patch. Comment on attachment 394597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394597&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:203 > + font-variant-numeric: tabular-nums; OpenType Font Features 💖️ Comment on attachment 394597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394597&action=review >>> Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:-224 >>> -video::-webkit-media-controls-time-remaining-display.hidden { >> >> Why do you remove this? > > Because there isn't any time remaining label. It's a bit unrelated to this patch, I realized working on this, but I can move it to its own patch. I would prefer you move it to its own patch but I don't care too much, your call. Committed r259191: <https://trac.webkit.org/changeset/259191> |