Bug 209593

Summary: [GTK][WPE] REGRESSION(r257775): Media controls current time label changes its size when it's updated
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, calvaris, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio
Priority: P2 Keywords: Gtk, Regression
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 209591    
Bug Blocks:    
Attachments:
Description Flags
Patch calvaris: review+

Carlos Garcia Campos
Reported 2020-03-26 05:46:26 PDT
This regressed in r257775 for me, because my system font doesn't use fixed width for digits. We should try to use the tabular-nums font variant if available.
Attachments
Patch (1.99 KB, patch)
2020-03-26 05:50 PDT, Carlos Garcia Campos 		calvaris: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-03-26 05:50:07 PDT
Created attachment 394597 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2020-03-26 06:06:36 PDT
Comment on attachment 394597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394597&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:-224 > -audio::-webkit-media-controls-time-remaining-display.hidden, > -video::-webkit-media-controls-time-remaining-display.hidden { Why do you remove this?
Carlos Garcia Campos
Comment 3 2020-03-26 06:12:52 PDT
(In reply to Xabier Rodríguez Calvar from comment #2) > Comment on attachment 394597 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394597&action=review > > > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:-224 > > -audio::-webkit-media-controls-time-remaining-display.hidden, > > -video::-webkit-media-controls-time-remaining-display.hidden { > > Why do you remove this? Because there isn't any time remaining label. It's a bit unrelated to this patch, I realized working on this, but I can move it to its own patch.
Adrian Perez
Comment 4 2020-03-26 07:02:00 PDT
Comment on attachment 394597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394597&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:203 > + font-variant-numeric: tabular-nums; OpenType Font Features 💖️
Xabier Rodríguez Calvar
Comment 5 2020-03-26 08:24:15 PDT
Comment on attachment 394597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394597&action=review >>> Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:-224 >>> -video::-webkit-media-controls-time-remaining-display.hidden { >> >> Why do you remove this? > > Because there isn't any time remaining label. It's a bit unrelated to this patch, I realized working on this, but I can move it to its own patch. I would prefer you move it to its own patch but I don't care too much, your call.
Carlos Garcia Campos
Comment 6 2020-03-30 02:35:12 PDT
Committed r259191: <https://trac.webkit.org/changeset/259191>
Note You need to log in before you can comment on or make changes to this bug.