Bug 209559

Summary:

WebPage::selectPositionAtPoint() does not focus an element in a non-focused frame

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, mifenton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
For the bots	none
Patch and test	none
Patch and test	none

Daniel Bates

Reported 2020-03-25 13:28:35 PDT

If the point passed to WebPage::selectPositionAtPoint() hits an element in a non-focused frame then it does nothing. This is ultimately because FrameSelection::setFocusedElementIfNeeded() early returns if the new focus element is not in a focused frame by [1] even though it is more than capable of accommodating the request: focusing the frame of the target element + focusing the target element (by way of calling FocusController::setFocusedElement()). [1] <https://trac.webkit.org/browser/trunk/Source/WebCore/editing/FrameSelection.cpp?rev=258233#L2246>

Attachments
For the bots (1.08 KB, patch) 2020-03-25 13:30 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch and test (4.15 KB, patch) 2020-03-25 15:26 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch and test (4.24 KB, patch) 2020-03-26 11:23 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.