| Summary: | [ews] commit-queue should comment on bug if it fails to find any modified ChangeLog | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2020-03-25 10:34:46 PDT
Created attachment 394516 [details]
Patch
Comment on attachment 394516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394516&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:2491 > + if self.getProperty('buildername', '').lower() == 'commit-queue': I'm r+ing this, but I feel like we've had this pattern a few different places. I wonder if we have justification for a more general 'write comment if commit queue' function, because I think this is the 3rd time we've done this recently. Comment on attachment 394516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394516&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:2491 >> + if self.getProperty('buildername', '').lower() == 'commit-queue': > > I'm r+ing this, but I feel like we've had this pattern a few different places. I wonder if we have justification for a more general 'write comment if commit queue' function, because I think this is the 3rd time we've done this recently. We can look into it, but probably not worth the effort. This is probably the last one in the series. Committed r258999: <https://trac.webkit.org/changeset/258999> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394516 [details]. |