Bug 209546

Summary: [Flatpak SDK] update-webkitgtk-libs fails
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Tools / TestsAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Description Philippe Normand 2020-03-25 10:06:16 PDT
Tools/Scripts/update-webkitgtk-libs
Updating Flatpak Release environment
Traceback (most recent call last):
  File "Tools/Scripts/update-webkit-flatpak", line 28, in <module>
    WebkitFlatpak.load_from_args(["--update"] + sys.argv[1:]).run()
  File "./Tools/flatpak/flatpakutils.py", line 713, in run
    self.update_all()
  File "./Tools/flatpak/flatpakutils.py", line 804, in update_all
    self.sdk_repo.flatpak("update")
  File "./Tools/flatpak/flatpakutils.py", line 141, in flatpak
    return subprocess.check_output(command).decode("utf-8")
  File "/usr/lib/python2.7/subprocess.py", line 223, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['flatpak', 'update', '--user']' returned non-zero exit status 1
Died at Tools/Scripts/update-webkitgtk-libs line 28.

We're missing a --assumeyes argument in the command.
Comment 1 Philippe Normand 2020-03-25 10:09:39 PDT
Created attachment 394512 [details]
Patch
Comment 2 Philippe Normand 2020-03-26 03:06:42 PDT
Committed r259039: <https://trac.webkit.org/changeset/259039>
Comment 3 Radar WebKit Bug Importer 2020-03-26 03:07:16 PDT
<rdar://problem/60912469>