| Summary: | Introduce @tryGetByIdWithWellKnownSymbol instead of repurposing @tryGetById itself | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||
| Component: | JavaScriptCore | Assignee: | Ross Kirsling <ross.kirsling> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=209363 | ||||||||
| Attachments: |
|
||||||||
|
Description
Ross Kirsling
2020-03-24 17:05:05 PDT
Created attachment 394445 [details]
Patch
Comment on attachment 394445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394445&action=review > Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1441 > + ASSERT(symbol); seems like we should release assert r=me. nice r=me too if EWS gets green :) Created attachment 394456 [details]
Patch for landing
Committed r258968: <https://trac.webkit.org/changeset/258968> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394456 [details]. |