| Summary: | [WebGL2] Update texture packing code for software uploads from DOM | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||
| Component: | WebGL | Assignee: | Kenneth Russell <kbr> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, justin_fan, kondapallykalyan, noam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 209510, 210766 | ||||||
| Attachments: |
|
||||||
Created attachment 397290 [details]
Patch
Comment on attachment 397290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397290&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4338 > + uint8_t* data = reinterpret_cast<uint8_t*>( > + pixels ? pixels->baseAddress() : nullptr); // NEEDS_PORT We tend to do this on one line. Comment on attachment 397290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397290&action=review >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4338 >> + pixels ? pixels->baseAddress() : nullptr); // NEEDS_PORT > > We tend to do this on one line. OK, will keep that in mind and fix this up in a subsequent patch. I'd like to try to get this in sooner so am CQ+'ing it now. Committed r260588: <https://trac.webkit.org/changeset/260588> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397290 [details]. |
The texture packing code for software texture uploads from DOM elements needs to be updated to support WebGL 2.0 formats. This includes code in: Source/WebCore/platform/graphics/FormatConverter.{cpp,h} Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp, GraphicsContextGLOpenGL::packPixels and others.