Bug 209513

Summary: [WebGL2] Context state updates
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, jdarpinian, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 205823, 208875, 209516, 209518, 210766, 213906    
Bug Blocks: 126404    
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2020-03-24 15:29:06 PDT
Updates are needed for WebGL 2.0 in the following methods which get and set global context state: getParameter getIndexedParameter isEnabled pixelStorei
Attachments
Patch (15.07 KB, patch)
2020-07-24 19:16 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2020-07-24 12:29:06 PDT
Taking this. Most if not all of these were already upgraded in other bugs.
Kenneth Russell
Comment 2 2020-07-24 14:42:25 PDT
With recent updates from Bug 208875, Bug 209518, Bug 213906, and others, getParameter appears to be complete.
Kenneth Russell
Comment 3 2020-07-24 14:55:25 PDT
With recent updates from Bug 205823, Bug 209518, Bug 213906, and perhaps others, getIndexedParameter appears to be fully implemented.
Kenneth Russell
Comment 4 2020-07-24 16:55:35 PDT
Looking into isEnabled and in particular validateCapability, it was found that a couple of methods were placed on WebGLRenderingContext earlier so that they could be overridden in WebGL2RenderingContext. Mmoving them to WebGLRenderingContextBase removes duplicated code, so will put up a patch for that. pixelStorei was completed in Bug 209516 and Bug 210766.
Kenneth Russell
Comment 5 2020-07-24 19:16:59 PDT
Created attachment 405216 [details] Patch
EWS
Comment 6 2020-07-25 12:49:01 PDT
Committed r264889: <https://trac.webkit.org/changeset/264889> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405216 [details].
Radar WebKit Bug Importer
Comment 7 2020-07-25 12:49:26 PDT
<rdar://problem/66107719>
Note You need to log in before you can comment on or make changes to this bug.