Bug 209509

Summary: Ignore in-app browser privacy checks for apps with com.apple.private.applemediaservices entitlement
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit Misc.Assignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Kate Cheney 2020-03-24 15:16:39 PDT 
These applications do not need the additional quirks provided by the in-app browser privacy checks.
Comment 1 Kate Cheney 2020-03-24 15:17:00 PDT 
<rdar://problem/60750956>
Comment 2 Kate Cheney 2020-03-24 15:23:57 PDT 
Created attachment 394423 [details]
Patch
Comment 3 Kate Cheney 2020-03-24 15:29:59 PDT 
Created attachment 394425 [details]
Patch
Comment 4 Brent Fulgham 2020-03-24 15:44:52 PDT 
Comment on attachment 394425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394425&action=review

Looks great! Just fix the include before landing.

> Source/WebKit/UIProcess/WebPageProxy.cpp:186
> +#include <wtf/cocoa/Entitlements.h>

This needs to be inside the #if PLATFORM(COCOA)
Comment 5 Kate Cheney 2020-03-24 15:51:11 PDT 
Created attachment 394428 [details]
Patch
Comment 6 Kate Cheney 2020-03-24 15:51:38 PDT 
Thanks! Just going to make sure this compiles on gtk before landing.
Comment 7 Brent Fulgham 2020-03-24 15:56:36 PDT 
Comment on attachment 394428 [details]
Patch

Perfect! r=me
Comment 8 EWS 2020-03-24 16:51:11 PDT 
Committed r258958: <https://trac.webkit.org/changeset/258958>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394428 [details].