| Summary: | Add user agent quirk for Red Hat Bugzilla | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aperez, bugs-noreply, calvaris, mcatanzaro | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
|
Description
Michael Catanzaro
2020-03-24 10:38:34 PDT
Created attachment 394381 [details]
Patch
Comment on attachment 394381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394381&action=review > Source/WebCore/platform/UserAgentQuirks.cpp:98 > + if (domain == "bugzilla.redhat.com") I find it a bit odd that a particular instance of Bugzilla needs a quirk, and others do not need it ¯\_(ツ)_/¯ This file looks like it's cross-platform, and so do function names. But this function is only used by WebCore/platform/glib/UserAgentGLib.cpp. We do occasionally have mostly cross-platform files that don't make sense on one particular platform. The quirks are separated from UserAgentGLib.cpp because they are intended to be entirely cross-platform. It's pretty likely that any websites causing problems for GLib ports will also be causing the same problems for Windows and PlayStation as well, for instance. I would recommend these quirks to any non-Apple port. If it would help avoid confusion, we could guard the whole thing with #if !PLATFORM(COCOA). (In reply to Adrian Perez from comment #2) > I find it a bit odd that a particular instance of Bugzilla > needs a quirk, and others do not need it ¯\_(ツ)_/¯ I see you haven't spent much time on Red Hat Bugzilla. :P It's really its own thing. Committed r259204: <https://trac.webkit.org/changeset/259204> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394381 [details]. |