| Summary: | Pass hardness for test numberingSystemsForLocale-cached-... through test header | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Paulo Matos <pmatos> | ||||||||
| Component: | New Bugs | Assignee: | Paulo Matos <pmatos> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ticaiolima, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Paulo Matos
2020-03-24 07:32:34 PDT
Created attachment 394365 [details]
Patch
Comment on attachment 394365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394365&action=review > JSTests/stress/numberingSystemsForLocale-cached-strings-should-be-immortal-and-safe-for-concurrent-access.js:2 > +//@ requireOptions("-e", "let hardness=25") if ["arm", "mips"].include?($architecture) It think it would be better if we had `if ["arm", "mips"].include?($architecture) then requireOptions("-e", "let hardness=25") else requireOptions("-e", "let hardness=100") end`. This way we avoid multiple calls to `requireOptions`. (In reply to Caio Lima from comment #2) > Comment on attachment 394365 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=394365&action=review > > > JSTests/stress/numberingSystemsForLocale-cached-strings-should-be-immortal-and-safe-for-concurrent-access.js:2 > > +//@ requireOptions("-e", "let hardness=25") if ["arm", "mips"].include?($architecture) > > It think it would be better if we had `if ["arm", > "mips"].include?($architecture) then requireOptions("-e", "let hardness=25") > else requireOptions("-e", "let hardness=100") end`. This way we avoid > multiple calls to `requireOptions`. We are only making a call here, unless it's arm or mips. I initially had followed your suggestion but the line length is a problem and unless there's a way to break a line in the test header, I see no way around it. Created attachment 394593 [details]
Patch
Created attachment 394608 [details]
Patch
Comment on attachment 394608 [details]
Patch
r=me
Committed r259114: <https://trac.webkit.org/changeset/259114> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394608 [details]. |